llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Group assignment and free text input #74

Closed AvinashAgarwal14 closed 5 years ago

llaske commented 5 years ago

Nice. Few remarks below. For Group assignment:

For Free-Text input:

llaske commented 5 years ago

Free text input:

image

Group assignment:

image

llaske commented 5 years ago

I do like the new component. Works very well! The border box around the selected group is a good idea. My remarks:

llaske commented 5 years ago

Ok nice. Regarding pastels colors, I would like ["#d3f6f3", "#f9fce1", "#fee9b2", "#fbd1b7"] instead of current one. There is a bug: create a matching pair exercise, play with it, everything work. Close the activity, click on play: every answer is bad.

llaske commented 5 years ago

Got an other error: create an exercise with 3 groups, put items in all groups, finish the exercise. Then edit the exercise and remove the third group. Run again, there is an error when item in the third group is submitted. Of course it's related to the fact that the item is linked to an unexisting group. It should be forbidden to remove a group with items inside. A message should be displayed in that case.