search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Edit mode created #89

Closed Uasked4dat closed 4 years ago

Uasked4dat commented 4 years ago

I can't find a dev branch in this case so I'm assuming that it's ok to commit to master, apologies if this is a mistake...

llaske commented 4 years ago

@thingthing could you review the structure of the code to ensure it respect ReactJS good practice?

Uasked4dat commented 4 years ago

Thanks for the tips on using ternaries, will definitely look into with more detail. Additionally, thanks for spotting the redundant code and they have been removed. :D

llaske commented 4 years ago

Very good job, that's exactly what we expected. BTW could you fix the tutorial because it don't match the new UI.

Uasked4dat commented 4 years ago

@llaske Tutorial has been fixed and is now compatible with the editor mode. Thanks :)

llaske commented 4 years ago

That's nice for the tutorial.

But there is an issue: it's no longer possible to share exercise. The button to share exercise don't appear like it should do:

share_exerciser1

Uasked4dat commented 4 years ago

Dear @llaske, I was overthinking the issue, turns out it was quite a quick fix. Please run the code while connected to the dev server or else share button will not appear (this was implemented by original developer). Additionally, I'm about to head towards the airport soon for my 12 hour flight so if there are still improvements to be made can you please grant me an extension on GCI? I will try my best to fulfil any requests while I'm at the airport also. Thanks! :D

Uasked4dat commented 4 years ago

Hi @llaske, I managed to fix the share issue in the airport, here is a demo: https://photos.app.goo.gl/MCGrf8mzP2uNQQyg9

Again, the share function does not work unless the development server is connected (i.e. built using npm and copied into sugarizer). Hope this is what you're looking for?

llaske commented 4 years ago

Very good job. Thanks. And thanks @thingthing for review.