search

llaske / sugarizer-server

Sugarizer Server allow deployment of Sugarizer on a local server, for example on a school server.
Apache License 2.0
42 stars 92 forks source link

"request" library has been deprecated #254

Closed NikhilM98 closed 4 years ago

NikhilM98 commented 4 years ago

The request library has been deprecated. According to Issue #3142 in its official repository, request will stop accepting new features and it will stop considering breaking changes. https://github.com/llaske/sugarizer-server/blob/6319475cb73cc2135d9cf3bcc08e677fd422e8b8/package.json#L27

This library is used in Sugarizer Server dashboard controllers to make HTTP requests.

We might need to replace request with alternatives.

I think superagent would be a good alternative as it supports callbacks.

NikhilM98 commented 4 years ago

@llaske @tarunsinghal92 what do you think?

tarunsinghal92 commented 4 years ago

Sounds good to me 👍

On Mon., Apr. 6, 2020, 2:57 p.m. Nikhil Mehra, notifications@github.com wrote:

@llaske https://github.com/llaske @tarunsinghal92 https://github.com/tarunsinghal92 what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/llaske/sugarizer-server/issues/254#issuecomment-609975986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWS7QMMTMSWA2NBILK33CDRLIQYHANCNFSM4MCQPMHA .

llaske commented 4 years ago

Oooch, bad news. Why not superagent but we have to evaluate first what it cost to change the code: lot of files are impacted. @NikhilM98 could you try to migrate on a small part (just in one isolated file) to test and measure the impact of the change?

NikhilM98 commented 4 years ago

@llaske sure. I'll do it.

NikhilM98 commented 4 years ago

Fixed in #260