search

llaske / sugarizer-server

Sugarizer Server allow deployment of Sugarizer on a local server, for example on a school server.
Apache License 2.0
42 stars 92 forks source link

show no result found message rather than Showing table headings #39

Closed ashish0910 closed 5 years ago

ashish0910 commented 5 years ago

On searching for User or Classroom through search option it shows only headings of the table if no matching result is found . The idea is to show user that no User or Classroom matching your search found message rather than showing only Table headings .

screenshot 2019-02-28 at 6 11 37 pm

llaske commented 5 years ago

Seems clear that there is no result found. It's the same behavior when looking for users.

ashish0910 commented 5 years ago

Yes , It's the same behaviour when looking for users. Showing such messages helps in better user experience . A message like this can be shown showing no User or Classroom found. screenshot 2019-03-02 at 1 11 49 am

tarunsinghal92 commented 5 years ago

@ashish0910 Could you please make a PR with a similar screen as shown above for classroom module.

ashish0910 commented 5 years ago

@tarunsinghal92 added in #44

llaske commented 5 years ago

Fixed in https://github.com/llaske/sugarizer-server/pull/44