search

llaske / sugarizer-server

Sugarizer Server allow deployment of Sugarizer on a local server, for example on a school server.
Apache License 2.0
42 stars 92 forks source link

code coverage #392

Open parteekcoder opened 1 year ago

parteekcoder commented 1 year ago

Hi @llaske @NikhilM98

Now the code coverage is implemented using 

"coverage": "nyc --exclude 'dashboard/**' mocha api/test/ --timeout 20000 --exit",

which generates output only on json format which is not so readable as we have many tests related to frontend and backend

parteekcoder commented 1 year ago

image

Output in this format can be more interactive and easy to read and check(debug)

NikhilM98 commented 1 year ago

It's visually appealing, but the people using Sugarizer Server probably won't be needing this feature. The CLI response should be sufficient for developers. These pages are useful when the project needs a dashboard for the operations team to monitor the health of the deployment, which does not seem to be necessary in our case.

However, the implementation is simple and it does not affects our code, so we can consider adding this feature.

@llaske what's your opinion on this?

llaske commented 1 year ago

I'm agree with you @NikhilM98. Unit testing and code coverage are for CLI and for GH actions. Mochawesome is nice but it's useless here.

parteekcoder commented 1 year ago

I'm agree with you @NikhilM98. Unit testing and code coverage are for CLI and for GH actions. Mochawesome is nice but it's useless here.

yeah no problem @llaske, I just want to propose a suggestion