search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 411 forks source link

MediaViewer activity empty. #1003

Closed AnandChourasia007 closed 1 year ago

AnandChourasia007 commented 2 years ago

The mediaviewer activity shows an empty page with no option of adding media to be viewed. The readme file too is empty and doesn't shed light on what the activity actually intends to do and how to use it. Also as the help button is missing, there is no way of knowing about the activity and its functions. Empty mediaviewer activity

llaske commented 2 years ago

It's deliberate. MediaViewer activity is not intended to be launch alone. It's a viewer for existing media content in the Journal.

AnandChourasia007 commented 2 years ago

In that case, I think it would be helpful to users if this information is written somewhere like a help button or to the future contributors if this is mentioned in the readme file for the activity. What do you think, @llaske ?

llaske commented 2 years ago

Hmmm. Why not. It could be an icon + a localized message in the background like the one when the Journal is empty.

image
AnandChourasia007 commented 2 years ago

Sure. I get it. I will do this and submit a PR soon.

AnandChourasia007 commented 2 years ago

Hey @llaske , is this good? MediaViewer empty message

llaske commented 2 years ago

That's the idea The message should be more simple: "Please open an existing media from the Journal".

llaske commented 2 years ago

Fixed in https://github.com/llaske/sugarizer/pull/1081