search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 411 forks source link

Fractions Activity: Add score counter #1032

Closed Shreyas-SAS closed 1 year ago

Shreyas-SAS commented 2 years ago

Issue: There seems to be no score counter in Fractions activity but only a check list on the top-left corner.

Suggestion: Add a score display so that progress can be better mapped using high scores and motivate kids to score higher.

Shreyas-SAS commented 2 years ago

@llaske please have a look once if this would be a good issue to resolve since we have a table already but not a score to map the number of correct answers.

llaske commented 2 years ago

Why not? Let's suggest a nice place and design to add the current score.

Shreyas-SAS commented 2 years ago

Why not? Let's suggest a nice place and design to add the current score.

thank you for your confirmation. I will be working on the issue asap and put a PR soon.

Shreyas-SAS commented 2 years ago

I am not able to work on the issue at the moment due to some academic commitments so if anyone is interested in working on the issue please feel free.

Shreyas-SAS commented 2 years ago

I am not able to work on the issue at the moment due to some academic commitments so if anyone is interested in working on the issue please feel free.

I will continue to work on the issue.

Ayeshashaik759 commented 1 year ago

Hlo @Shreyas-SAS if you don't mind can I work on this issue. My suggestion is I have observed that in fraction activity at each turn we have 10 chances so the max high score can be 10 so is it okay to display just score each time. I tried to display the score in the following way(i.e on the top right side in case of mobile we can change its position to center) the score is set to 0/10 at the start of each turn. @llaske please share your view on this changes.

Screenshot (128)

Screenshot (127)

in the below video you can see how the score is reset of each turn(i.e after 10 chances).

https://user-images.githubusercontent.com/101845170/217256818-8d70a8c0-6dd9-4bd3-bfb8-517685f31198.mp4

Shreyas-SAS commented 1 year ago

Hlo @Shreyas-SAS if you don't mind can I work on this issue. My suggestion is I have observed that in fraction activity at each turn we have 10 chances so the max high score can be 10 so is it okay to display just score each time. I tried to display the score in the following way(i.e on the top right side in case of mobile we can change its position to center) the score is set to 0/10 at the start of each turn. @llaske please share your view on this changes.

Screenshot (128)

Screenshot (127)

in the below video you can see how the score is reset of each turn(i.e after 10 chances).

https://user-images.githubusercontent.com/101845170/217256818-8d70a8c0-6dd9-4bd3-bfb8-517685f31198.mp4

Yeah sure. Please do. I lost the code that I implemented before creating a pr. Please continue. I do not wish to work on it.

Ayeshashaik759 commented 1 year ago

@llaske I tried adding score counter to the fraction activity. I tested it in the web browser I hope it is working fine. please check my pr and share your view on it.

llaske commented 1 year ago

@Ayeshashaik759 thanks. See my comments on your PR.

llaske commented 1 year ago

Fixed in https://github.com/llaske/sugarizer/pull/1185