In Paint activity on resizing the window it crops the canvas instead of resizing it

[disha1202]

Current behaviour

screen-recorder-thu-sep-01-2022-17-44-12.webm

Expected behaviour

screen-recorder-thu-sep-01-2022-17-37-51.webm

[llaske]

The drawing should not be resized because it will lost its proportion. A drawing is not like an image. So it's not a bug.

[disha1202]

The drawing should not be resized because it will lost its proportion. A drawing is not like an image. So it's not a bug.

Alright, if that is the case then maybe we can remove the onResize function (https://github.com/llaske/sugarizer/blob/dev/activities/Paint.activity/js/paint-activity.js#L53) and this line of code (https://github.com/llaske/sugarizer/blob/dev/activities/Paint.activity/js/paint-activity.js#L47)

@llaske What do you think?

[llaske]

I don't think so. The canvas should be resize in this event.

[disha1202]

Yes, the canvas is resized when you change the screen size and on this resize event we have called a function onResize where the first line of code is a return statement. This function ends before performing any computation and will not affect the current behaviour if removed.

Please let me know if I'm missing something?

[llaske]

Oh :open_mouth: you're right! The Resize method is useless

[disha1202]

So should we remove it?

[llaske]

@disha1202 yes please.