llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

Extra icon rendering in QRCode activity #1193

Open S-kus opened 1 year ago

S-kus commented 1 year ago

image 1

image 2 It can be corrected by adding -webkit-appearance: none;

abhishektiwari47 commented 1 year ago

Hey can explain this problem... On adding -webkit-appearance: none; nothing happened.

abhishektiwari47 commented 1 year ago

Yes I got the issue I would Like to work on this...

abhishektiwari47 commented 1 year ago

@llaske Please reply, Would you like to give this issue to me?

abhishektiwari47 commented 1 year ago

I have resolved this issue please assign this issue to me.

disha1202 commented 1 year ago

Hi @abhishektiwari47, There's nothing like assigning issue here, you can directly create a PR if there is no other PR linked.

abhishektiwari47 commented 1 year ago

Actually I had created some changes yesterday but there was no response. That's why I thought I should ask first

By the way, is this the same repo that is mentioned in GSOC 23 project ideas

On Mon, Feb 27, 2023, 14:58 Disha Talreja @.***> wrote:

Hi @abhishektiwari47 https://github.com/abhishektiwari47, There's nothing like assigning issue here, you can directly create a PR if there is no other PR linked.

— Reply to this email directly, view it on GitHub https://github.com/llaske/sugarizer/issues/1193#issuecomment-1445988632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVAAZN5PM6KFT7NQ7EXZCVTWZRXS5ANCNFSM6AAAAAAVHGBFMI . You are receiving this because you were mentioned.Message ID: @.***>

Vishalk91-4 commented 1 year ago

This issue is fixed in #1394

llaske commented 1 year ago

@Vishalk91-4 it fixes the first part of the issue (loading svg), not the second part (extra icon).

Vishalk91-4 commented 1 year ago

@Vishalk91-4 it fixes the first part of the issue (loading svg), not the second part (extra icon).

I did match the code of both the background and the dropdown in it, so the extra icon is not visible now

llaske commented 1 year ago

The small arrow for drop down is still visible

image

Vishalk91-4 commented 1 year ago

The small arrow for drop down is still visible

image

Sorry missed it, will fix it soon, since my semester exams are starting tomorrow

llaske commented 6 months ago

Fixed in https://github.com/llaske/sugarizer/pull/1583