llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 411 forks source link

Speak activity UI enhancement #1201

Closed Ydvaaman closed 1 year ago

Ydvaaman commented 1 year ago

Hey @llaske . I have a suggestion for the Speak Activity. The separator separating the text box and the activity container has an incomplete length. So, what we can do is we can expand the length of the separator so it will look more symmetric than before. For reference I have attached screenshots for the same, please look and review them and give me your thoughts. If you find it an issue then I would like you to assign this issue to me :)

Before

Screenshot (27)

After

Screenshot (28)

llaske commented 1 year ago

Yes why not.

Ydvaaman commented 1 year ago

hey @llaske
I have raised a PR for the above Speak activity UI enhancement please refer to my PR at https://github.com/llaske/sugarizer/pull/1210

llaske commented 1 year ago

Fixed in https://github.com/llaske/sugarizer/pull/1210

sarvesh-kumar-code commented 1 year ago

Hey @llaske As we are on speak activity you can see in the input box the arrow button is not aligned properly.

before

WhatsApp Image 2023-02-28 at 9 15 46 PM

after

image

Kindly share your thoughts on this.

llaske commented 1 year ago

@sarvesh-kumar-code I don't see any change on my side on this.

rockharshitmaurya commented 1 year ago

@llaske Actually this is a new issue: the alignment of the button on the text bar is not correct. It is currently looking like this: WhatsApp Image 2023-03-01 at 2 47 35 AM

and it can be further improved like this :

WhatsApp Image 2023-03-01 at 2 47 35 AM

if you think this is an issue , we will be happy to fix this

llaske commented 1 year ago

Hmmm. There is no issue on my side.

image

rockharshitmaurya commented 1 year ago

Based on my observations, the alignment issue with the button on the text bar appears to be screen size-dependent. While the button may appear to be correctly aligned on your desktop screen, it appears to be slightly off on my desktop screen and other screens I have tested. Therefore, I suggest that we further refine the alignment to ensure that it is accurately aligned across different desktop screens. This will help to enhance the user experience and ensure the consistent presentation of the button across multiple devices.

llaske commented 1 year ago

@rockharshitmaurya for which screen size there is an issue?