search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

QR activity Photo Loading Icon Overlaping #1268

Closed kanishkcs closed 6 months ago

kanishkcs commented 1 year ago

Hey @llaske

the Image loading icon , and Drop Down icon is overlapping Each other in the Photo Activity of QR activity

image

We can fix it ,by keeping it next to the drop down icon like this image

Please share your thought on this.

llaske commented 1 year ago

You're right but I think the spinner should be set under the bar near the camera.

kanishkcs commented 1 year ago

Ok @llaske , can i have a marked area , where you want particulary the spinner?

llaske commented 1 year ago

@kanishkcs do the best you can

kanishkcs commented 1 year ago

hey @llaske image

as per your suggestion i have put the loading spinner under the bar , near the camera, kindly review changes and provide feedback if you want any further improvement.

llaske commented 1 year ago

No I think it's better to put the spinner in the white zone under the arrow. Not in the search bar.

kanishkcs commented 1 year ago

Hey @llaske

Preview of the Changes: image

I have raised the Pr #1334 , kindly Review it. If any further changes is required do let me Know.

Thanks and Regards.

llaske commented 1 year ago

Fixed in https://github.com/llaske/sugarizer/pull/1394