search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 411 forks source link

QR code Activity: Bug in full screen mode #1298

Closed VedantSharma11 closed 1 year ago

VedantSharma11 commented 1 year ago

hey @llaske

In the QR code activity I have found a bug, when we switch to full screen mode the functionality bar below the top navbar becomes invisible but we are still able to use it, whereas it should be visible in fullscreen mode also .

Solved in PR:https://github.com/llaske/sugarizer/pull/1301

I am attaching video for reference pls give your thoughts.

Video

How it is:

https://user-images.githubusercontent.com/96445392/223362444-d86c79ff-ee98-45ff-b7c2-e94b7a6e88a3.mp4

After: Removing the functionality in fullscreen mode so that by mistake if the user types anything and press enter the qr will not change

https://user-images.githubusercontent.com/96445392/224069932-21dacbd6-0239-4069-a4f0-933a4266c962.mp4

llaske commented 1 year ago

Full screen mode in QR code activity is just for displaying the code to be able to share it. The users don't click on the board when in full screen mode. It's not an issue.

VedantSharma11 commented 1 year ago

@llaske okay then I think we can completely remove its functionality when in fullscreen mode , As when fullscrren mode is activated the left dropdown and the textbox all are functional but not visible. Pls give your thoughts on this suggestion

llaske commented 1 year ago

No. We can keep it.