search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 411 forks source link

Fix: Align buttons better #135

Closed sanatankc closed 5 years ago

sanatankc commented 6 years ago

This is how (prev | next | end) buttons looks like now, which is not ideal in any way. Doesn't looks good by any UX perspective. screen shot 2017-12-04 at 1 56 18 pm

It would look better if it looked something like this.

try sugarizer org_

kunal-mohta commented 6 years ago

This can be easily fixed using <center> tags. Where is this HTML code in the repository??

sanatankc commented 6 years ago

Don't use center tags, they are deprecated.

kunal-mohta commented 6 years ago

I have also been able to achieve the same using CSS flex-box.

sanatankc commented 6 years ago

Yeah, I was going suggest FlexBox :D On 24-Dec-2017 10:17 PM, "k-cap" notifications@github.com wrote:

I have also been able to achieve the same using CSS flex-box.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/llaske/sugarizer/issues/135#issuecomment-353793822, or mute the thread https://github.com/notifications/unsubscribe-auth/ATbgicD-rp6EAyarqbzCBuURdiO9ghK4ks5tDoA2gaJpZM4Q0Sr_ .

kunal-mohta commented 6 years ago

@llaske What do you think?

llaske commented 6 years ago

Why not. Do a try and send a PR. BTW avoid to update the library itself (Bootstrap tour) in your change.

s1db commented 6 years ago

If this is still open and no one is working on it, I'd like to take this up. 😄

kunal-mohta commented 6 years ago

I am not working on this right now, so if @sanatankc is not doing this, then I guess you can try this.

llaske commented 5 years ago

Template for tutorial is located here https://github.com/llaske/sugarizer/blob/dev/lib/tutorial.js#L19

llaske commented 5 years ago

Fixed in https://github.com/mchlp/sugarizer/commit/4a7937f3b151e3f40f7fb66f08f4d19d021f38d8