llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

Misalignment of close button on intro dialog boxes #1428

Closed VishnuVardhanBR closed 8 months ago

VishnuVardhanBR commented 9 months ago

The close button on the intro dialog boxes in dev.sugarizer.com are bugged, whereas on server.sugarizer and try.sugarizer they are fine.

dev bugged button

Upon comparing them on both the websites, there is an additional line-height property for the introjs-skipbutton class in the dev site, which when removed fixes the issue. This property is missing on the other sites.

Screenshot 2023-12-20 at 5 30 12 PM
llaske commented 9 months ago

Guess it's related to the fix https://github.com/llaske/sugarizer/issues/1403 I'm afraid that if we remove this line, the problem will happen again. Any suggestion?

VishnuVardhanBR commented 9 months ago

I believe we can remove the line. I've checked the behaviour on multiple pages after its removal, and the button remains clickable with no issues.

llaske commented 9 months ago

No the line-height is need else there is shift on the cross (forced in blue below).

image

BTW, to fix the issue it's possible to set the color to transparent.

VishnuVardhanBR commented 9 months ago

Setting to transparent works, but when I try to reproduce what you have done above I receive the expected result? Why might this be?

Screenshot

Screenshot

llaske commented 9 months ago

Setting to transparent works, but when I try to reproduce what you have done above I receive the expected result? Why might this be?

It seems that the alignment depend on resolution. Increase the zoom to change the alignment.

VishnuVardhanBR commented 9 months ago

I'm confused, It still works fine on lower resolutions, tried zooming in, reducing window size, manually setting resolution in dev tools.

Screenshot

llaske commented 9 months ago

I mean related to physical screen resolution, changing screen size in Chrome has no effect.

llaske commented 8 months ago

Fixed in https://github.com/llaske/sugarizer/pull/1461