search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 415 forks source link

[v2] password.js Component Issues #1515

Closed UtkarshSiddhpura closed 8 months ago

UtkarshSiddhpura commented 9 months ago

Issues found

  1. Long pressing keys doesn't work: we could ignore other keys but being not able to long-press backspace could be annoying to users.
  2. Ctrl keys combination: e.g ctrl+a, ctrl+backspace.

Possible Fixes

  1. Handle all long presses or only backspace key.
  2. Remove text highlights of input selection. Handle ctrl+backspace by checking e.target.value === "".
Vishalk91-4 commented 8 months ago

@UtkarshSiddhpura, @llaske, another thing I've found is that if I press any key let's say a, then the letter get's displayed till it's pressed, then the emoji is displayed only once

Vishalk91-4 commented 8 months ago

I'm fixing this issue now, will raise the PR

llaske commented 8 months ago
  1. I don't think supporting long press key is a good idea. It could be difficult to understand for young children. But you're right long press on backspace key should work.
  2. Ctrl keys could be ignored (it's not supported in v1). It's not intuitive for children. BTW the current behavior is weird on Ctrl+a and should be fixed.
llaske commented 8 months ago

Close by https://github.com/llaske/sugarizer/pull/1519 and https://github.com/llaske/sugarizer/pull/1527