fix #1516 sugar_history get removed when user delete its account

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser

https://sugarizer.org

Apache License 2.0

199 stars 423 forks source link

Closed riteshsinghh-coder closed 9 months ago

riteshsinghh-coder commented 9 months ago

Fix #1516 sugar_history get removed when user delete its account so user doesnot show on first page

llaske commented 9 months ago

Nice. It fix the issue but:

[ ] I'm not a big fan of the fix, it will be better to avoid the exception than catching it
[ ] Please respect the code indentation (TAB instead of SPACE)

UtkarshSiddhpura commented 9 months ago

@llaske Also do you think that we should somehow store the user already fetched on mount rather then re-fetching the user. or it's okay to refetch? https://github.com/llaske/sugarizer/blob/9e5c7c45283d21a1361a07e38938fa0c9ab39b2b/v2/js/screens/settings-myprivacy.js#L106-L108

llaske commented 9 months ago

Nice. Thanks. That's fine to reload the user @UtkarshSiddhpura