search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 412 forks source link

Fixed, ctrl + a and ctrl + backspace functionalities #1519

Closed Vishalk91-4 closed 7 months ago

Vishalk91-4 commented 7 months ago

Fixes issue #1515

https://github.com/llaske/sugarizer/assets/116670999/388c97d8-6e2d-4268-b4e5-4d1fdf2def1d @llaske could you please review this PR, I haven't fixed things for long pressing

llaske commented 7 months ago

It's a partial fix, following is a Ctrl+A following by Del

KWlIC47P77

llaske commented 7 months ago

Hmmmm. The behavior is weird: multiple letters replaced by one emoji.

lmq0OuW004

It's not the case in v1.

UtkarshSiddhpura commented 7 months ago

I think rather handling every actions of user, we could go for more minimal effort just like it's in v1 That's why i raised another PR #1527

llaske commented 7 months ago

Good idea @UtkarshSiddhpura. BTW the Ctrl +a and Ctrl + backspace has to be fixed.

UtkarshSiddhpura commented 7 months ago

BTW the Ctrl +a and Ctrl + backspace has to be fixed.

Isn't my PR fixes it or we want some modified behavior than v1?

llaske commented 7 months ago

Isn't my PR fixes it or we want some modified behavior than v1?

@UtkarshSiddhpura We could add the handling of CTRL+A and CTRL+Backspace that was not handled in v1 @Vishalk91-4 I'm not sure to understand the commit https://github.com/llaske/sugarizer/pull/1519/commits/4a9e84c04a63c3a810538a05d75c72df6edff04e

Vishalk91-4 commented 7 months ago

Isn't my PR fixes it or we want some modified behavior than v1?

@UtkarshSiddhpura We could add the handling of CTRL+A and CTRL+Backspace that was not handled in v1 @Vishalk91-4 I'm not sure to understand the commit 4a9e84c

@llaske, that commit 4a9e84c was due to conflicting files, fter some updation in password.js

Vishalk91-4 commented 7 months ago

@llaske Now, I have correctly added the ctrl + a and backspace, selection of text at any point in password and pressing any key replaces the selected one with that key, or backspace removes the selected part

Could you please review it now

llaske commented 7 months ago

That's nice @Vishalk91-4 , it fix the issue. There is still an issue, it's possible to type illegal characters (i.e. characters not matching an emoji)

N767ALGOLb

Vishalk91-4 commented 7 months ago

@llaske I have fixed those non mapping characters, also I mistakenly added just A to function as ctrl + , changed it to ctrl + A

llaske commented 7 months ago

Nice @Vishalk91-4 . Thanks.