fix: Update tests to accommodate changes in v2 and test utils API

[llaske]

Nice start but there is still a failed test.

[UtkarshSiddhpura]

Nice start but there is still a failed test.

All tests are passing on my side can you locate which test is failing? It's probably 1 of the four.

[llaske]

It's in password component

[UtkarshSiddhpura]

Nice start but there is still a failed test.

Resolved

[llaske]

That's nice but is it possible to remove all console.warn?

[UtkarshSiddhpura]

I guess all the warnings are related to props datatypes (for e.g icon x , y accepts Number but all the implemented-screens/components-using-icon are passing it a string) So should i change the prop data-type or everywhere it's passing it as string?

[llaske]

@UtkarshSiddhpura I think that it's okay for x, y or color to be a number but there is no reason to force id to be a number.

[UtkarshSiddhpura]

@llaske I think we should setup something so before pushing or before merging we run all the test cases to avoid potential errors and warnings

[llaske]

Not sure to understand. What do you want to setup? What prevents to fix warnings?

[UtkarshSiddhpura]

Not sure to understand. What do you want to setup? What prevents to fix warnings?

Something like a pre-push hook that only pushes if all the test are passed @llaske You can merge this PR for now I'll open another PR if we're interested in pre-push hook

[llaske]

Good job. Thanks.

Something like a pre-push hook that only pushes if all the test are passed

Got it. You mean action to launch unit testing before commit? I think it's more something to put in Github actions (like for Sugarizer Server here).