llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
199 stars 423 forks source link

Replaced WebL10n with i18next in Markdown activity #1533

Closed VishnuVardhanBR closed 9 months ago

VishnuVardhanBR commented 9 months ago

Fixes #1378 Locales work, no errors.

llaske commented 9 months ago

In case of fallback, the sample text is not localized. What is it:

image

What it should be:

image

VishnuVardhanBR commented 9 months ago

Unable to reproduce, any specific steps?

Screenshot

llaske commented 9 months ago

Unable to reproduce, any specific steps?

Hmmm. Guess you're running Sugarizer App locally (using Electron or file:///), I've tested on a local Sugarizer server. It can make a difference because there is a delay loading files.

VishnuVardhanBR commented 9 months ago

I'm unable to reproduce on the server. I tried throttling the cpu and network using devtools, but couldn't see the issue, is there any another way?

Screenshot 2024-02-20 at 1 22 34 AM
llaske commented 9 months ago

Step to reproduce: 1) Change Sugarizer language to Igbo 2) Open popup menu for Markdown activity 3) Create a new instance (do not open an existing one)

I guess the problem is that this line could be executed before locale initialization. The solution could be to wait for the localized event to initialize value for a new instance.

VishnuVardhanBR commented 9 months ago

I guess the problem is that this line could be executed before locale initialization.

Most likely. I can fix it but I just can't reproduce it to test before committing, please take a look below.

https://github.com/llaske/sugarizer/assets/64434937/4572747b-7462-42fb-8807-b00d4c007143

llaske commented 9 months ago

Strange. It happens each time on my side.

wE9tB0e4a7

VishnuVardhanBR commented 9 months ago

I made some changes but i'm unable to validate whether it works or not, what do I do?

Vishalk91-4 commented 9 months ago

@llaske

I tried in my system as well, it's showing the same thing, perhaps a localization issue Screenshot 2024-02-25 183233

soham2312 commented 8 months ago

@llaske please review the Indentation changes