FIXED : Display a message when there is no activity matching the search in listview

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser

https://sugarizer.org

Apache License 2.0

199 stars 423 forks source link

FIXED : Display a message when there is no activity matching the search in listview #1561

Closed hharshas closed 8 months ago

hharshas commented 8 months ago

@llaske Can you review this again ?

llaske commented 8 months ago

@llaske Can you review this again ?

Look like nothing has changed since my previous review.

hharshas commented 8 months ago

@llaske I localized the texts as you told me to do. Is there something else that I am missing and I have to do ?

llaske commented 8 months ago

@llaske I localized the texts as you told me to do. Is there something else that I am missing and I have to do ?

Yes, see comments on the review https://github.com/llaske/sugarizer/pull/1561/files/c87feda844d05640f652382b1d7bbc651addb2d7

hharshas commented 8 months ago

@llaske I am moving offtrack and unable to understand what to do so here is the summary of all the changes that I have brought. Motive : Display a message when there is no activity matching the search in listview. Further Changes :-

[x] fix: the add of prefix ":". https://github.com/llaske/sugarizer/pull/1561#pullrequestreview-1937734840 (remove ':')
[x] Text must be localized. https://github.com/llaske/sugarizer/pull/1561#discussion_r1526401023 (add Sugar.l10n)

Total 6 Files, 60 lines Changed in 9 commits Please comment below for further assistance...

hharshas commented 8 months ago

@llaske Ohk will resolve these...