search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
199 stars 424 forks source link

Show message when there is no activity matching the search (listview) #1561 #1573

Closed hharshas closed 7 months ago

hharshas commented 8 months ago

@llaske #1561 TODO.md

hharshas commented 8 months ago

@llaske Can you review this ?

llaske commented 8 months ago

It's nice but the icon and the message appears during 1 second before loading the activity. Would be nice to avoid it.

By1rJlW7er

hharshas commented 7 months ago

@llaske review the changes.

llaske commented 7 months ago

That's nice but because Sugarizer is use by children and some of them can't read, it's always better to avoid text. I suggest to replace it by the spinner-light.gif already in the repo.

hharshas commented 7 months ago

@llaske there is no image folder in v2, so I've called the gif from outside, but there should be one isn't it ?

llaske commented 7 months ago

Yes

hharshas commented 7 months ago

@llaske so can I copy one to v2 ?

llaske commented 7 months ago

Yes copy it instead of referencing the original, the v1 directory is supposed to be removed at end

hharshas commented 7 months ago

@llaske You can check the changes now.

llaske commented 7 months ago

Nice but please add only the spinner-light.gif from now

hharshas commented 7 months ago

@llaske yeah adding other assets will be make it messy for now !!!!

llaske commented 7 months ago

Good job. Thanks.