search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 412 forks source link

Fixes #1453 #1580

Closed SamarthBagga closed 4 months ago

SamarthBagga commented 5 months ago

Fixes #1453 Updated the help text if someone clicks on play then pause after one game is over.

SamarthBagga commented 5 months ago

@llaske , could you please review this PR ?

Vishalk91-4 commented 5 months ago

https://github.com/llaske/sugarizer/assets/116670999/0b850155-3f66-4add-8aa0-14368c9fa544

@SamarthBagga, I don't think this fixed the issue, it didn't work in my device Maybe @llaske could check on his device and verify the same

SamarthBagga commented 5 months ago

@Vishalk91-4, Thanks for pointing this out! This problem was arising due to the fact that the Score inner html length is zero at the start of the game when no rounds have been played but when the user has played a round and gotten a score out of ten for that then the string has a length but is equal to " ". I have made the necessary edits for the same, you can try it again.

Vishalk91-4 commented 5 months ago

@Vishalk91-4, Thanks for pointing this out! This problem was arising due to the fact that the Score inner html length is zero at the start of the game when no rounds have been played but when the user has played a round and gotten a score out of ten for that then the string has a length but is equal to " ". I have made the necessary edits for the same, you can try it again.

Works for me now

llaske commented 4 months ago

Nice. Thanks @SamarthBagga