llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 412 forks source link

[v2] Password section - Empty Password Works #1594

Closed Vishalk91-4 closed 4 months ago

Vishalk91-4 commented 5 months ago

In the Password section in V2 even with empty password it allows the clicking to next and with enter key, It should be restricted

https://github.com/llaske/sugarizer/assets/116670999/8ca78835-94c4-4477-8a34-424c99725ded

llaske commented 4 months ago

:open_mouth: Well done! The minimal size should even be checked: https://github.com/llaske/sugarizer/blob/dev/js/firstscreen.js#L183

Vishalk91-4 commented 4 months ago

😮 Well done! The minimal size should even be checked: https://github.com/llaske/sugarizer/blob/dev/js/firstscreen.js#L183

Yes, I was thinking of adding that, even if it wasn't mentioned The minimal size should be kept to 4 right

llaske commented 4 months ago

The minimal size should be kept to 4 right

Yes this is the default minimal size but the server keep the control on the real minimum.

llaske commented 4 months ago

Fixed in https://github.com/llaske/sugarizer/pull/1599