search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

Missing flag handling in ColorMyWorld #1603

Open llaske opened 5 months ago

llaske commented 5 months ago

When there is a missing flag for a country in ColorMyWorld, the popup display undefined before the country name. It will be better to display nothing in this case.

2t7nCztPC7

vraj-712 commented 5 months ago

But i think you want to remove that undefined part, right ? not whole pop up box

vraj-712 commented 5 months ago

Can you please describe how you want that?? because i am unable to understand your requirements

llaske commented 5 months ago

Can you please describe how you want that?? because i am unable to understand your requirements

The fix suggested by @hharshas is good but is not enough. It solve the case where there is no existing emoji matching the country name in the activity. But like I mentioned here, there is an existing emoji for St Vincent Grenadines. The problem is that the name mentioned in the flag constant doesn't match the name of the country so just changing the value to Saint_Vincent_and_the_Grenadines will make the flag appears. So it should be nice to fix the value and double-check values for other countries.

piyushmishraa commented 3 months ago

hi i would like to work on this issue.Can you assign it to me

hharshas commented 3 months ago

@piyushmishraa you can start working on it and also read the contribution guidelines first as it is mentioned there that there's no need to be assigned in an approved issue.

piyushmishraa commented 3 months ago

got it,thanks :)

yashveeeeer commented 1 month ago

@llaske i have made some changes could you review it and i also have some doubts.

llaske commented 1 month ago

@yashveeeeer thanks for your contribution.

BTW your PR is not a the right place. It should be done on this repo. See https://github.com/llaske/sugarizer/blob/dev/CONTRIBUTING.md for more.

Plus, as I mentioned here it will be nice to check other missing flags.

yashveeeeer commented 1 month ago

Thanks alot @llaske I'll take care of the original repo and I'll check that problem you mentioned.

llaske commented 2 weeks ago

Fixed in https://github.com/llaske/sugarizer/commit/461795ebeb5171f80e707f6b559ae0a42f86be3f