search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

improvement in "Missing flag handling in ColorMyWorld" issue #1604

Closed hharshas closed 4 months ago

hharshas commented 5 months ago

Added a condition to display name only if flag is not defined. #1603 @llaske

llaske commented 5 months ago

Sounds nice. BTW I've just checked and the matching Emoji exist: https://emojipedia.org/flag-st-vincent-grenadines It's probably a name mismatch with the one declared in flag.js: https://github.com/llaske/sugarizer/blob/dev/activities/ColorMyWorld.activity/lib/flag.js#L221 Should be interesting to fix it and to ensure there is no mismatch in the flag list.

Fun with flags :laughing:

llaske commented 4 months ago

@hharshas do you still work on this PR?

hharshas commented 4 months ago

Naah @llaske I am busy rn, you can assign it to others.

piyushmishraa commented 3 months ago

hi i would like to work on this issue ...can you assign it to me please ?