llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
199 stars 422 forks source link

Optimize coloring of homescreen icons. #1628

Closed UtkarshSiddhpura closed 5 months ago

UtkarshSiddhpura commented 5 months ago

Before:

https://github.com/llaske/sugarizer/assets/90092555/2335b33e-18e2-47af-8d15-e7d6ce70aefd

After:

https://github.com/llaske/sugarizer/assets/90092555/a2e3c5a1-8af3-4980-8bda-e7a3d1412db1

llaske commented 5 months ago

Waoow, the result is great :star_struck:

Few things however regarding the icon implementation:

UtkarshSiddhpura commented 5 months ago
  • [x] I'm not a big fan of the name waitForLoad, why not just wait
  • [x] It will be nice to be able to wait for the non native format too, so the promise should be set
  • [x] It will be nice to add an unit test on this new method
UtkarshSiddhpura commented 5 months ago

Done

llaske commented 5 months ago

It will be nice also to fix the sandbox.html page because it's a good to have a real test of native/non native icon. This page no longer work since the migration to i18next.

llaske commented 5 months ago

Just seen that the fix doesn't work in file:/// mode:

INj42DPCQA

The page should be manually refreshed to display icon colors.