search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
195 stars 410 forks source link

Neighborhood view & UI Enhancements #1635

Closed UtkarshSiddhpura closed 1 week ago

UtkarshSiddhpura commented 3 weeks ago

Screen demo:

NV

Connect to server in App

App

llaske commented 3 weeks ago

The activity icon should disappear when no user are connected:

image

UtkarshSiddhpura commented 3 weeks ago

@llaske ✅ Activities on screen with no users ✅ file:/// not showing server not set 3

You can merge this PR i'll open another PR for icon Component issues

1644

llaske commented 3 weeks ago

Few remarks:

M926p1nyw0

gT5IX80q0w

llaske commented 3 weeks ago

9kPsgdP4gZ

UtkarshSiddhpura commented 3 weeks ago

  • [x] The icon for join popup should be colored like in v1

  • [ ] The handling of server connection in file:/// mode seems incompatible with v1

The handling is like v1 but i guess you already have saved setting for user server in local storage that's why the server is already set.

serverset

UtkarshSiddhpura commented 3 weeks ago
  • [ ] Sounds like activities icons could be lost on slow network

I cannot reproduce the issue on fast3G and not even on slow3G

slow3

llaske commented 3 weeks ago

The handling is like v1 but i guess you already have saved setting for user server in local storage that's why the server is already set.

I don't understand your point: the local storage is share between v1 and v2 so if it's set in v2 it should be set for v1. So refreshing the page in v1 should do the same in v2.

Oy709EKM1Z

llaske commented 3 weeks ago

I cannot reproduce the issue on fast3G and not even on slow3G

Hmmm. I reproduce it each time. Steps to reproduce:

o5L8lbPZ1A

UtkarshSiddhpura commented 3 weeks ago
  • Open Sugarizer in a browser, connect an user and share an activity
  • Open a private browser window, open Sugarizer and connect with another user
  • Go to Neighborhood view: everything is okay
  • Change network to Fast 3G
  • Refresh the page: the app icon is missing

Using chrome nw-1

UtkarshSiddhpura commented 3 weeks ago

I don't understand your point: the local storage is share between v1 and v2 so if it's set in v2 it should be set for v1. So refreshing the page in v1 should do the same in v2.

It works now (also clear the local storage for a fresh start)