llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

Fixed undefined emoji #1643

Closed piyushmishraa closed 2 weeks ago

piyushmishraa commented 3 months ago

fixed the flag emoji by changing name of country to correct one https://github.com/llaske/sugarizer/issues/1603

https://github.com/llaske/sugarizer/assets/116213566/45d41d77-f12c-415e-9683-14d66410a0f6

llaske commented 3 months ago

Nice. But should be cool to ensure there are no other issues on flags. In short: ensure that all countries names in geojson files match a country in flag.js file. Could be automatized. What do you think?

piyushmishraa commented 3 months ago

That sounds nice..let me work on it .

piyushmishraa commented 3 months ago

hi @llaske ..so i was getting familiar with the code base and i noticed that in map.js,target name and tool_display was being matched and taken care of .i still didnt get why we got this error after this.However, I am still trying to figure out a way so that countries in geojson and flag.js match.if you have something you can guide me. other thing was the emoji for French Southern Territories was missing so i took care of that.Rest of the flags are alright .

llaske commented 3 months ago

My idea is to extract the list of existing countries in the app and comparing it to flag list. For example, one way to do that could be to:

@piyushmishraa make sense?

piyushmishraa commented 3 months ago

Hmm makes sense👍, getting back to work ✌🏼

llaske commented 1 month ago

@piyushmishraa do you still work on it?

llaske commented 2 weeks ago

Fixed in https://github.com/llaske/sugarizer/commit/461795ebeb5171f80e707f6b559ae0a42f86be3f