Closed piyushmishraa closed 2 months ago
Nice. But should be cool to ensure there are no other issues on flags.
In short: ensure that all countries names in geojson
files match a country in flag.js
file.
Could be automatized.
What do you think?
That sounds nice..let me work on it .
hi @llaske ..so i was getting familiar with the code base and i noticed that in map.js,target name and tool_display was being matched and taken care of .i still didnt get why we got this error after this.However, I am still trying to figure out a way so that countries in geojson and flag.js match.if you have something you can guide me. other thing was the emoji for French Southern Territories was missing so i took care of that.Rest of the flags are alright .
My idea is to extract the list of existing countries in the app and comparing it to flag list. For example, one way to do that could be to:
world.geojson
, europe.geojson
, ... and put it in a CSV file order by name (and deduplicated). flag.js
and put it in a CSV order by name (and with _ replaced by white space).@piyushmishraa make sense?
Hmm makes sense👍, getting back to work ✌🏼
@piyushmishraa do you still work on it?
fixed the flag emoji by changing name of country to correct one https://github.com/llaske/sugarizer/issues/1603
https://github.com/llaske/sugarizer/assets/116213566/45d41d77-f12c-415e-9683-14d66410a0f6