search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
199 stars 422 forks source link

Fix selectbox tests #1645

Closed UtkarshSiddhpura closed 3 months ago

llaske commented 4 months ago

Could you fix conflicts?

llaske commented 4 months ago

There is still warnings and issues in the sandbox

image

UtkarshSiddhpura commented 4 months ago

There is still warnings and issues in the sandbox

Resolved, the sandbox is working fine in feature/v2, I pushed the wrong changes, Should i resolve the warnings too?, It's mostly related to passing wrong prop data type, which i already fixed before for other screens, but not sandbox

llaske commented 4 months ago

Should i resolve the warnings too?, It's mostly related to passing wrong prop data type, which i already fixed before for other screens, but not sandbox

Yes please.

llaske commented 3 months ago

There is still issues on the selectBox:

5o5r2qb6v1