llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
199 stars 423 forks source link

Vertical bar are broken in Chart/Gears activities on Windows #1646

Open llaske opened 4 months ago

llaske commented 4 months ago

On Chrome Window, the vertical bar used in activities toolbar to split group of icons is broken.

It look like:

image

and should be:

image

Issue is both on Chart and Gears activity

hharshas commented 4 months ago

yeah, actually the issue persists in one of the the other activity also (I don't remember it clearly) but the problem is in file sugarweb lib's sugar-200dpi.css file, with hr tags, rather than these particular activities. We need to make changes in each activity I guess.

llaske commented 4 months ago

@hharshas do you know a way to fix it to ensure it will works in all environments?

hharshas commented 4 months ago

Nothing comes to my mind easier than changing the hr tag's style in all of the activities's lib folder manually, so we can avoid this error in the future use of hr tags inside the toolbar classes in any activity. @llaske I guess if you are aware of any other way to make changes at one place and it will automatically update all sugarweb library's style files, that may come in handy.

llaske commented 4 months ago

I guess if you are aware of any other way to make changes at one place and it will automatically update all sugarweb library's style files, that may come in handy.

I've got script to do the job to copy a file changed in sugarweb in every activity. My question was more: could we find a simple implementation of the hr tag that will work in any environment (any OS any browser)?

hharshas commented 4 months ago

@llaske, I need to spend some time going through the code base and other things. I'm quite busy with my internship, but if the issue remains unresolved for a while, I'll make sure to look into it.

MdSaifAliMolla commented 3 months ago

@llaske fixed it. #1654

AdityaKrSingh26 commented 4 days ago

Hey @llaske could you please have a look at my pr (#1673)