search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
199 stars 422 forks source link

unable to play the recorded video in the record activilty #1664

Closed yashveeeeer closed 1 month ago

yashveeeeer commented 1 month ago

fixing issue #1203 and #1661

yashveeeeer commented 1 month ago

@llaske would you please review it.

llaske commented 1 month ago

Smart fix. Thanks. Did you had opportunity to test on others operating system than Windows? As you know, Sugarizer is multi-platform so the fix should work on every platform. I've read that VP8 has broader compatibility, especially in older devices and software. May be it could be better to use VP8 than VP9.

yashveeeeer commented 1 month ago

Thanks @llaske, Yeah I will try to see the fix on different OS using Virtual Machine. and you are right about VP8 has broader compatibility on older devices than VP9, I just read that , I will change it to that after checking the fix on different OS.

yashveeeeer commented 1 month ago

kindly ignore that force push, it was done mistakenly truth is I was trying something I have changed VP9 to VP8, I have also check the fix on Linux. actually the video player is working fine in Linux, the problem is only with the windows environment, when I added the fix the video was still working fine with Linux.

llaske commented 1 month ago

Thanks a lot for fixing this very old bug.

yashveeeeer commented 1 month ago

My pleasure, I learned a lot, from this bug.