search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

Turtle Blocks Activity hangs on Android App #185

Closed manki11 closed 5 years ago

manki11 commented 6 years ago

The turtle blocks activity hangs in Android App, when the Load Samples from web icon is clicked (world icon in top right menu). After clicking on the button , any other click after that registers as a load samples from web.

error

Not facing any similar behaviour on sugarizer web.

Device Tested on- Oneplus 5T Android 7.0.1

llaske commented 6 years ago

Seems that load samples don't work neither on web version. There is a JavaScript issue here: https://github.com/llaske/sugarizer/blob/dev/activities/TurtleBlocksJS.activity/js/samplesviewer.js#L213

image
divyabaid16 commented 6 years ago

I would like to work on this issue. Can you plz guide me ?

llaske commented 6 years ago

Turtle Blocks activity come from https://github.com/walterbender/turtleblocksjs.git . I suggest you to fork this repository, and try to understand how it works by studying the code. Then you could see what's wrong when running on the Sugarizer environment.

utkarsh-raj commented 5 years ago

https://github.com/llaske/sugarizer/pull/279#issue-255672546

A part of the error has been fixed by cleaning the String before parsing with the parse function. I cannot test the complete functions because the sugarizer server probably does not allow the request without CORS headers which are not present by default in the request.

Nonetheless, the problem is fixed. Please review @llaske .

utkarsh-raj commented 5 years ago

The commit is updated @llaske .

llaske commented 5 years ago

Fixed in https://github.com/llaske/sugarizer/pull/279

llaske commented 5 years ago

Closed in https://github.com/llaske/sugarizer/commit/dd3c58d56981e4dfa6d94601b95d7117a3bc9241