search

llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
197 stars 411 forks source link

Change background colour of speak activity according to XO color #310

Closed prabhupant closed 5 years ago

prabhupant commented 5 years ago

the background of speak activity always remains blue. According to me it should change with the XO colors in order to look more appealing and follow the design principles of sugar.

ashish0910 commented 5 years ago

@prabhupant Looks like it does :

Screenshot 2019-03-26 at 2 25 30 PM Screenshot 2019-03-26 at 2 28 27 PM Screenshot 2019-03-26 at 2 28 52 PM

Check here: https://github.com/llaske/sugarizer/blob/a5c440a214fafbdc6aac9d3c9f9043edac8d7f93/activities/Speak.activity/js/SpeakActivity.js#L21

llaske commented 5 years ago

@prabhupant it change color only if you change buddy colors then opening a new instance of the activity (from the activity list view or from the menu item "new instance" in activity menu item)

prabhupant commented 5 years ago

@llaske shouldn't it be instantly, like when you change the buddy color, the color of icons and this background color should change?

llaske commented 5 years ago

No, it don't. It's related to entries in the Journal. Old entries use old colors, new entries (or old entries reopen) use new colors.