llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

Grammatical Errors in the Documentation #347

Closed IbukunF closed 5 years ago

IbukunF commented 5 years ago

While I was going through the Sugarizer tutorial, I noticed some areas in the tutorial and the application with grammatical errors:

  1. Step 6 of the tutorial:

    • There is a line that says "Suppose that Michaël, an user connected on the same server than you want to Chat." that could be better written as "Suppose that Michaël, a user connected on the same server as you wants to Chat.".
  1. Step 4 of the tutorial:
  1. README of EbookReader activity:
  1. Finally, In the second screen of the popup modal tutorial, the sentence "First, you need an user to associate your content." could also be changed to "First, you need a user to associate your content with."
IbukunF commented 5 years ago

The screen mentioned in 4 is shown here image I think this can be fixed by modifying the file called template.pot at line 1302 but I would like some feedback first before making that change. The other changes have been made in a pull request.

@llaske please review this when you have a chance

llaske commented 5 years ago

Thanks. Please send a PR on the dev branch. Regarding error on tutorial screen, the file to update is locale.ini. PO/POT files in Sugarizer are generated from the .ini file. See https://github.com/llaske/sugarizer/tree/dev#localization for more.

llaske commented 5 years ago

Closed in https://github.com/llaske/sugarizer/commit/dd3c58d56981e4dfa6d94601b95d7117a3bc9241