llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

Add a fullscreen button in the Reflection activity #399

Closed llaske closed 4 years ago

llaske commented 4 years ago

Sugarizer activities don't look good on devices with small screen - for example smartphones. On these devices, the toolbar could sometimes take 1/4 of the screen.

image

To increase the size for activities contents, the idea is to add a fullscreen button in the toolbar, like in the QRCode activity.

image

When clicked, the fullscreen button hide the toolbar and display only an unfullscreen button.

image

When clicked, the unfullscreen button show again the toolbar.

This features is implemented here.

The objective of this issue is to implement the same feature in the Reflection activity.

Thinks to check:

est271 commented 4 years ago

I would like to work on this issue but i have one question before i begin.

I cloned the dev branch and I am able to successfully launch the platform on the sugarizer-server and all the features on sugarizer seem to work just fine.

the only thing is that there is some unit test failures on my dev branch without any modifications being made. Currently running on Linux Mint and I'm wondering if its due to my system and settings or maybe its other issues that are still being worked on? Attached is a screenshot

u_test1

Most of the other failures have similar Error messages

est271 commented 4 years ago

Actually never mind about my previous question. I get the same results from the Sugarizer Web Application, creating a user and navigating over to try.sugarizer.org/test/index.html

llaske commented 4 years ago

Fixed in https://github.com/llaske/sugarizer/pull/420