llaske / sugarizer

Sugarizer is a web implementation of the Sugar platform to run on any device or browser
https://sugarizer.org
Apache License 2.0
198 stars 411 forks source link

MazeWeb: Show Red Face On Start #69

Closed davelab6 closed 7 years ago

davelab6 commented 8 years ago

IN http://server.sugarizer.org/activities/MazeWeb.activity/index.html the starting state has a grey circle for the player and a bright flashing color for the exit.

This is confusing because it brings attention to the exit at the start instead of the player.

screen shot 2016-07-09 at 12 11 39

I suggest having the red face of the player rendered in the starting state, rather than having it appear:

screen shot 2016-07-09 at 12 11 46
SudhanvaMG commented 7 years ago

Hey , i would like to work on this . Can you let me know how do i proceed ?

llaske commented 7 years ago

You had to explore the code of the activity and try to understand where is the face changing. Send a PR when you've done

DarkPrince304 commented 7 years ago

@llaske In case of two player, which players face should we show? Given both are of different color?

Or should the solution be to have the red colour nevertheless?

rajeevravindran commented 7 years ago

How about this? I've set the initial position as a red player. screenshot_20170313_155006

Becomes gray after the player moves. screenshot_20170313_155056

rajeevravindran commented 7 years ago

@llaske Worth a pull request?

llaske commented 7 years ago

Fixed in https://github.com/llaske/sugarizer/commit/cc8fabeebc6938769e4d728efb92a3a1d9be4907