[Color My World/Try version] Error between the two Korea

[Eric38fr]

In the "Color my World" activity (french version of Try Sugarizer, "https://try.sugarizer.org/activities/ColorMyWorld.activity/index.html?aid=ebbbaf9a-2355-4428-93bc-bd6a7dbc651a&a=org.sugarlabs.ColorMyWorldActivity&o=87fdb363-5699-4605-a190-e289d3eb70bb&n=Activité%20ColorMyWorld"), when playing in interactive mode, if it shows the (north) Korea label and shape, I had to click of the south Korea in order to colorize it, and conversely with the Republik of Korea, which is the South Korea, to be clicked on the north one. The shapes in the transcient "guess" dialog are well associated with the corresponding names, it's just the targets to be clicked which seem to have been exchanged. Best regards, and thanks for the tool. -- Éric

[llaske]

Thanks, you're right. But the issue seems limited to the Asian view, it works in the World view.

Sound like there is a name issue in asia.geojson file: Korea string should be North Korea and South Korea should be North Korea. Guess that just updating this file should solve the issue.

[llaske]

Fixed in https://github.com/llaske/sugarizer/pull/899

@Eric38fr, you could test the fix on the dev server here: https://dev.sugarizer.org

[Eric38fr]

@llaske: Okay, I have just verified in the dev.sugarizer.org instance, Asian view, and it's now okay.

Other issues (should I have open a new one ? it shall be in the same file, I guess), still in the dev.sugarizer.org instance, "Color my World" module, world view, interactive mode:

• The West Bank question dialog shows the shape of Israel, and by the way, in french, West Bank is Cisjordanie. The Israel question dialog shape is okay.
• There is also Somalia shape which includes {{Somaliland}} (which is what UNO reckognizes), therefore Somaliland is in both zones (just as far as question dialog shapes are concerned — hard to test more while "playing" :-) ). No good suggestion, sorry — maybe, a small icon stating it's the UNO definition, could possibly help, here and in other places…
  • The Island of Cyprus, in french "Chypre", is also a difficulty : the "Chypre" question shape shows the whole island, while the clickable zone is only the "(south part of) Republic of Cyprus" (see below this screen capture, just after I clicked — and sorry for the green sea, a forgotten try :-) ). I suggest that you make the precision of "Isle of Cyprus", "île de Chypre", which is geographic and not geopolitical !
  • finally, I got "Northern Chypre" (as far as I remember, part in english, part in french, but not sure…), with the question shape for the island, but the clickable answer, the limited northern part (which is not politically reckognized by UNO).

I stop for the moment. Maybe others, next week-end…

[llaske]

Yes please, fill a new issue for these remarks.

@ccosse could you give use your opinion about these questions.

[ccosse]

@llaske/sugarizer sugarizer@noreply.github.com I will try to have a look asap ... could be couple days until I have time, but I will follow-up. Thanks

On Tue, Nov 24, 2020 at 12:22 PM Lionel Laské notifications@github.com wrote:

Yes please, fill a new issue for these remarks.

@ccosse https://github.com/ccosse could you give use your opinion about these questions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/llaske/sugarizer/issues/898#issuecomment-733212749, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIBUVPKMA3SDDZHF6FKRLLSRQIXPANCNFSM4TZ6V6IQ .

--

ccosse.github.io

[ccosse]

I fixed West Bank and Somaliland ... @Eric38fr how are you seeing French translations when those seem to be disabled now? I could add those translations but it would not matter since fr is no longer enabled.

[llaske]

To see another language you need to change it in Sugarizer: go back on home view, right click on buddy icon to display menu then click on settings item then language. So choose French to see French language.

[ccosse]

Tried to address all things mentioned here ... N. Cyprus is clickable for me ... changed name as suggested and added any missing N. Cyprus entries throughout. Copied Palestine.png to West\ Bank.png. If you see something in double curly braces, like {{Somaliland}}, it means that the feature was present in the main geojson file but the translation of the feature name (ie country name) was not found. For images such as N Cyprus, the popup country images were made by extracting country features from a different, larger geojson file. The game, meanwhile, uses a simplified geojson file, and apparently the simple geojson differentiates between Cyprus and N. Cyprus, whereas the original used to make the pictures did not. Hence the lack of picture for N/S Cyprus. The existing image could be broken into 2 but didn't do that.

[llaske]

@Eric38fr I've open a new issue here: https://github.com/llaske/sugarizer/issues/901 @ccosse fixed it in https://github.com/llaske/sugarizer/pull/900. The fix is published on https://dev.sugarizer.org. Let us know if you find other issues.