Closed remicollet closed 9 years ago
other related to incomplete classe reference
I think you should rebuild the database (I did not published sqlite db for a long time), and push only a new version with a release now
5 related to Imagick 3.3.0RC1
Only Imagick 3.1.2 (stable) is supported. See reference:list
command
5-6 fixed by pr #175
On my windows laptop, with a fresh built DB and your PR #173 only, I got these results
PHPUnit 4.5.1 by Sebastian Bergmann and contributors.
Configuration read from C:\home\github\php-compat-info\phpunit.xml
............................................................ 60 / 1368 ( 4%)
............................................................ 120 / 1368 ( 8%)
............................................................ 180 / 1368 ( 13%)
............................................................ 240 / 1368 ( 17%)
............................................................ 300 / 1368 ( 21%)
......................SSSSSSSSSSSS.......................... 360 / 1368 ( 26%)
.....................SSSSSSSSSSSS........................... 420 / 1368 ( 30%)
....................SSSSSSSSSSSS.......................SSSSS 480 / 1368 ( 35%)
SSSSSSS.......................SSSSSSSSSSSSSSSSSSSSSSSS...... 540 / 1368 ( 39%)
.............................SSSSSSSSSSSSSSSSSSSSSSSS....... 600 / 1368 ( 43%)
........................................SSSSSSSSSSSS........ 660 / 1368 ( 48%)
...SSSSSSSSSSSS...................................SSSSSSSSSS 720 / 1368 ( 52%)
SS.......................SSSSSSSSSSSSSSSSSSSSSSSS........... 780 / 1368 ( 57%)
............................................................ 840 / 1368 ( 61%)
............................................................ 900 / 1368 ( 65%)
............SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS...........S 960 / 1368 ( 70%)
SSSSSSSSSSSSSSSSSSSSSSS...........SSSSSSSSSSSSSSSSSSSSSSSSSS 1020 / 1368 ( 74%)
SSSSSSSSSS.................................................. 1080 / 1368 ( 78%)
.............................................SSSSSSSSSSSS... 1140 / 1368 ( 83%)
............................................................ 1200 / 1368 ( 87%)
............................................................ 1260 / 1368 ( 92%)
............................................................ 1320 / 1368 ( 96%)
..................................
Time: 3.34 minutes, Memory: 29.00Mb
OK, but incomplete, skipped, or risky tests!
Tests: 1126, Assertions: 14766, Skipped: 264.
I'm still analysing your PR #172 to see why we have 4590 tests while previously we have only 1368
I'm still analysing your PR #172 to see why we have 4590 tests while previously we have only 1368
Because 1 test per constant instead of 1 test per extension (but number of assertion should be nearly the same)
Ok, with a fresh db (1 and 2 are Gmp + Http)
3) Bartlett\Tests\CompatInfo\Reference\Extension\RedisExtensionTest::testGetClassConstantsFromExtension
Defined class constant 'Redis::SERIALIZER_IGBINARY' not known in Reference.
Failed asserting that an array has the key 'SERIALIZER_IGBINARY'.
/work/GIT/php-compat-info/tests/Reference/GenericTest.php:616
4) Bartlett\Tests\CompatInfo\Reference\Extension\SphinxExtensionTest::testGetClassMethodsFromExtension
Defined method 'SphinxClient::close' not known in Reference.
Failed asserting that an array has the key 'close'.
/work/GIT/php-compat-info/tests/Reference/GenericTest.php:566
5) Bartlett\Tests\CompatInfo\Reference\Extension\StompExtensionTest::testGetClassMethodsFromExtension
Defined method 'Stomp::nack' not known in Reference.
Failed asserting that an array has the key 'nack'.
/work/GIT/php-compat-info/tests/Reference/GenericTest.php:566
6) Bartlett\Tests\CompatInfo\Reference\Extension\VarnishExtensionTest::testGetClassConstantsFromExtension
Defined class constant 'VarnishLog::TAG_Debug' not known in Reference.
Failed asserting that an array has the key 'TAG_Debug'.
/work/GIT/php-compat-info/tests/Reference/GenericTest.php:616
Defined class constant 'Redis::SERIALIZER_IGBINARY' not known in Reference.
Probably a wrong windows version build. I have the latest version 2.2.7 got from pecl.php.net
And only php --re redis
- Classes [3] {
Class [ <internal:redis> class Redis ] {
- Constants [19] {
Constant [ integer REDIS_NOT_FOUND ] { 0 }
Constant [ integer REDIS_STRING ] { 1 }
Constant [ integer REDIS_SET ] { 2 }
Constant [ integer REDIS_LIST ] { 3 }
Constant [ integer REDIS_ZSET ] { 4 }
Constant [ integer REDIS_HASH ] { 5 }
Constant [ integer ATOMIC ] { 0 }
Constant [ integer MULTI ] { 1 }
Constant [ integer PIPELINE ] { 2 }
Constant [ integer OPT_SERIALIZER ] { 1 }
Constant [ integer OPT_PREFIX ] { 2 }
Constant [ integer OPT_READ_TIMEOUT ] { 3 }
Constant [ integer SERIALIZER_NONE ] { 0 }
Constant [ integer SERIALIZER_PHP ] { 1 }
Constant [ integer OPT_SCAN ] { 4 }
Constant [ integer SCAN_RETRY ] { 1 }
Constant [ integer SCAN_NORETRY ] { 0 }
Constant [ string AFTER ] { after }
Constant [ string BEFORE ] { before }
}
Defined method 'SphinxClient::close' not known in Reference.
Can't test, due to a wrong windows build. I've the latest version 1.3.2 get from pecl.php.net Even after load test
deplister.exe php_sphinx.dll
php5ts.dll,OK
WS2_32.dll,OK
MSVCR110.dll,OK
KERNEL32.dll,OK
I have no results with php re --sphinx
Exception: Extension sphinx does not exist
Forget my previous comment about sphinx. I've redownloaded the win ver from pecl and now it's loadable
Even if my windows version of sphinx is now loadable. There are differences between the reflection I got and your https://github.com/remicollet/remirepo/blob/master/php/pecl/php-pecl-sphinx/REFLECTION
Missing in Windows version 1.3.2
Constant [ integer SPH_RANK_PROXIMITY ] { 4 }
Constant [ integer SPH_RANK_MATCHANY ] { 5 }
Constant [ integer SPH_RANK_FIELDMASK ] { 6 }
Constant [ integer SPH_RANK_SPH04 ] { 7 }
Constant [ integer SPH_RANK_EXPR ] { 8 }
Constant [ integer SPH_RANK_TOTAL ] { 9 }
And
Method [ <internal:sphinx> public method close ] {
- Parameters [0] {
}
}
Method [ <internal:sphinx> public method open ] {
- Parameters [0] {
}
}
Method [ <internal:sphinx> public method setSelect ] {
- Parameters [1] {
Parameter #0 [ <required> $clause ]
}
}
Method [ <internal:sphinx> public method setOverride ] {
- Parameters [3] {
Parameter #0 [ <required> $attribute ]
Parameter #1 [ <required> $type ]
Parameter #2 [ <required> $values ]
}
}
Method [ <internal:sphinx> public method status ] {
- Parameters [0] {
}
}
Of course, there is a quick solution, to solve this situation. Not the best one, but the faster. Deactivated reference "fully documented" in https://github.com/llaville/php-compat-info/blob/4.0/tests/Reference/GenericTest.php#L57
What do you think of this one ?
SERIALIZER_IGBINARY is an optional constant, only defined when build with --enable-redis-igbinary option
About sphinx, those constants are optional (depend on libsphinx client)
About varnish and your PR #176, the windows version 1.2.1 did not inclued them
Class [ <internal:varnish> class VarnishLog ] {
- Constants [0] {
}
And comparing with your REFLECTION file, I see also a diff on visibility method (public on my side) https://github.com/remicollet/remirepo/blob/master/php/pecl/php-pecl-varnish/REFLECTION#L251
About varnish and your PR #176, the windows version 1.2.1 did not inclued them
See comment on PR #176 and additioonal commit on PR #172
Ok I read and see comment on PR #176. Sorry but I can't merge yet the PR #172. I'd like to have a separate commit that fixed only varnish class constant on VarnishExtensionTest.php
Nevermind, class constants are not yet checked with the GenericTest::testGetConstantsFromReference()
method (excluding your PR #172)
About sphinx methods missing (previous comment https://github.com/llaville/php-compat-info/issues/174#issuecomment-88409783), I just see that there are optional (depend on libsphinxclient ) E.g: http://php.net/manual/en/sphinxclient.close.php
All are fixed now.
Bug tracker for failed tests