search

llaville / php-compatinfo

Library that find out the minimum version and the extensions required for a piece of code to run
https://llaville.github.io/php-compatinfo/7.1/
Other
371 stars 21 forks source link

Mass method signature mismatch #286

Closed szepeviktor closed 3 years ago

szepeviktor commented 3 years ago

Please consider running phpstan analyze src/ -l 2

( fastest way to get there: phive install phpstan )

Many classes do not match PhpParser\NodeVisitor

llaville commented 3 years ago

It's a QA process that will be apply in v6. I won't spend more time than necessary on v5.4 Anyway thanks for your recommandation

llaville commented 3 years ago

Commits :

szepeviktor commented 3 years ago

https://twitter.com/szepeviktor/status/1359481979092230144 👁️‍🗨️

llaville commented 3 years ago

Feel free to close this issue, if it look good to you !

szepeviktor commented 3 years ago

Thank you for your work.