search

llaville / php-compatinfo

Library that find out the minimum version and the extensions required for a piece of code to run
https://llaville.github.io/php-compatinfo/7.1/
Other
371 stars 21 forks source link

Make major version 6.0 compatible with PHP 8.1 #308

Closed llaville closed 2 years ago

llaville commented 2 years ago

CI Unit tests report https://github.com/llaville/php-compatinfo/runs/4472349033?check_suite_focus=true

OK (221 tests, 615 assertions)

Remaining self deprecation notices (3)

  1x: Return type of Bartlett\CompatInfo\Application\Collection\SniffCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
    1x in ParameterTest::functionProvider from Bartlett\CompatInfo\Tests\Reference

  1x: Return type of Bartlett\CompatInfo\Application\Sniffs\KeywordBag::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
    1x in ParameterTest::functionProvider from Bartlett\CompatInfo\Tests\Reference

  1x: Return type of Bartlett\CompatInfo\Application\Sniffs\KeywordBag::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
    1x in ParameterTest::functionProvider from Bartlett\CompatInfo\Tests\Reference
llaville commented 2 years ago

Fixed with commit https://github.com/llaville/php-compatinfo/commit/c049bfa05ef6c7b2a5c73328b2bc45cf5bddeb02