search

llaville / php-compatinfo

Library that find out the minimum version and the extensions required for a piece of code to run
https://llaville.github.io/php-compatinfo/7.1/
Other
371 stars 21 forks source link

[6.0.2] compatibility with Symfony 4 #316

Closed remicollet closed 2 years ago

remicollet commented 2 years ago

regression #310 is back

The fix is in master but not in 6.0 branch

PHP Fatal error: Declaration of Bartlett\CompatInfo\Application\Event\Dispatcher\EventDispatcher::dispatch(object $event, ?string $eventName = null): object must be compatible with Symfony\Component\EventDispatcher\EventDispatcher::dispatch($event) in ...

remicollet commented 2 years ago

Fix for #309 is also missing...

llaville commented 2 years ago

Thanks for reporting, I'll fix it now

llaville commented 2 years ago

Two commits (fixes) was git cherry-picked from master branch to synchronize branch 6.0

remicollet commented 2 years ago

Also missing in 6.1 branch ?

llaville commented 2 years ago

no, I've just checked it

llaville commented 2 years ago

FYI: I plan to release the v6.1.0 in 3 days

llaville commented 2 years ago

@remicollet FYI (#317) ; php-compatinfo-db 3.17.0 will be released tomorrow

llaville commented 2 years ago

Feel free to reopen this issue, if you think I've missed something