search

llaville / php-compatinfo

Library that find out the minimum version and the extensions required for a piece of code to run
https://llaville.github.io/php-compatinfo/7.1/
Other
373 stars 20 forks source link

PHP 8.4 runtime support #376

Open llaville opened 2 weeks ago

llaville commented 2 weeks ago

Summary

Add support to PHP 8.4 runtime

Description

llaville commented 2 weeks ago

Fix PHP 8.4 deprecation about Implicitly nullable parameter declarations with commit https://github.com/llaville/php-compatinfo/commit/6349a1bd46c4e21be357c4938eacd20929660cf0

llaville commented 2 weeks ago

One more PHP 8.4 deprecation fixed by commit https://github.com/llaville/php-compatinfo/commit/aaa8950fa25f69b11a4f22b59e410143d2bdd199

llaville commented 2 weeks ago

Even if deprecations exists (it's for bartlett/sarif-php-sdk package that is not yet compatible with PHP 8.4, but will come soon)

Running unit tests with DB built on tests environment, with following command : 

APP_ENV=tests vendor/bin/phpunit --configuration phpunit.xml.dist

Prints these output : 

PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.0RC3
Configuration: /shared/backups/bartlett/php-compatinfo/phpunit.xml.dist

......D........................................................  63 / 153 ( 41%)
............................................................... 126 / 153 ( 82%)
...........................                                     153 / 153 (100%)

Time: 00:04.342, Memory: 70.00 MB

OK, but there were issues!
Tests: 153, Assertions: 333, Deprecations: 2.
llaville commented 2 weeks ago

Requires these configs https://github.com/llaville/php-compatinfo/commit/aaeec85f03aa7e3fa578eafa9bfb8ed64af6ed49 to run with PHP 8.4

llaville commented 2 weeks ago

For Info : my comment related is bartlett/sarif-php-sdk is only for version 1.x; Major version 2.0.x does not suffer this PHP 8.4 incompatibility.

llaville commented 2 weeks ago

No deprecations with bartlett/sarif-php-sdk 2.0.1 installed 

PHPUnit 10.5.38 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.0RC3
Configuration: /shared/backups/bartlett/php-compatinfo/phpunit.xml.dist

...............................................................  63 / 153 ( 41%)
............................................................... 126 / 153 ( 82%)
...........................                                     153 / 153 (100%)

Time: 00:04.434, Memory: 72.00 MB

OK (153 tests, 333 assertions)
llaville commented 19 hours ago

Version 7.2.0 that will support PHP 8.4 will come shortly now https://github.com/llaville/php-compatinfo-db/releases/tag/6.13.0 was released