search

llaville / php-compatinfo

Library that find out the minimum version and the extensions required for a piece of code to run
https://llaville.github.io/php-compatinfo/7.1/
Other
371 stars 21 forks source link

References in foreach are not considered #56

Closed staabm closed 11 years ago

staabm commented 11 years ago

phpci reports php4.1 for the following file https://github.com/redaxo/redaxo4/blob/4.4.1/redaxo/include/addons/textile/classes/class.textile.inc.php

Since this file uses a call-by-ref inside a foreach-loop, see https://github.com/redaxo/redaxo4/blob/4.4.1/redaxo/include/addons/textile/classes/class.textile.inc.php#L1543, this is not correct.

It should be something arround php5.x

jdlx commented 11 years ago

Following is the call i used on the mentioned file and phpci's output (phpci version 2.11.0):

$ phpci -vvv print --report summary .../textile-2.4.1/classTextile.php 
1 / 1 [+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++>] 100.00%

-------------------------------------------------------------------------------
PHP COMPAT INFO REPORT SUMMARY
-------------------------------------------------------------------------------
FILES                         EXTENSIONS INTERFACES CLASSES FUNCTIONS CONSTANTS
-------------------------------------------------------------------------------
BASE: .../textile-2.4.1
-------------------------------------------------------------------------------
DIR.: 
classTextile.php                      4          0       1        47        31
-------------------------------------------------------------------------------
A TOTAL OF 
 4 EXTENSIONS 1 CLASS 47 FUNCTIONS 31 CONSTANTS 
WERE FOUND IN 1 FILE
WITH CONDITIONAL CODE LEVEL 5
REQUIRED PHP 4.1.0 (MIN) 
-------------------------------------------------------------------------------
Time: 0 seconds, Memory: 10.50Mb
-------------------------------------------------------------------------------
llaville commented 11 years ago

Hello,

Sorry to reply so long after you've opened the ticket. But I won't fix it. The parser engine I used now (PHP_Reflect) is limited in its features and is not ready to detect such condition.

Thanks anyway.