llbooya / qb-phone-npstyle

NP style edits and additionals for qb-phone, originally mostly done by AmirExpert, help from a few community members. NOT PROVIDING SUPPORT
58 stars 54 forks source link

Phone stuck on screen after hangup #36

Closed Jxmes-Devs closed 2 years ago

Jxmes-Devs commented 2 years ago

We have an issue in our server where if someone hangs up the call, the person who did not open their phone to hangup will keep the phone & call notification on their screen, If they open the phone at any point after the call, both the notification will disappear and they will have to close their phone again as normal. This is occuring with a fresh install of this resource. It is almost as if the container it is trying to remove isnt referenced but as I am not the best in .js I have been unable to prove this theory.

I did notice that after having the call hang up the person who did not hang up receives the below NUI error: (I've left this here even though I believe this to also appear after hanging up on the default qb-phone aswell)

Uncaught TypeError: Cannot read property 'icon' of undefined (@qb-phone/html/js/app.js:629)

Howsn commented 2 years ago

This is the same error I have, then its not only me. If anyone got a fix for this I would love if you could share :D

trclassic92 commented 2 years ago

We have an issue in our server where if someone hangs up the call, the person who did not open their phone to hangup will keep the phone & call notification on their screen, If they open the phone at any point after the call, both the notification will disappear and they will have to close their phone again as normal. This is occuring with a fresh install of this resource. It is almost as if the container it is trying to remove isnt referenced but as I am not the best in .js I have been unable to prove this theory.

I did notice that after having the call hang up the person who did not hang up receives the below NUI error: (I've left this here even though I believe this to also appear after hanging up on the default qb-phone aswell)

Uncaught TypeError: Cannot read property 'icon' of undefined (@qb-phone/html/js/app.js:629)

Can you please make a recreation video for us so we can see the issue.... Currently we are not seeing any issues with this...

Jxmes-Devs commented 2 years ago

I noticed after recording this I didnt show the console but as mentioned in the original this is recreatable by any player at any time, all they have to do is hangup during a phonecall and as seen in the first clip it will stay on their screen

https://streamable.com/u6t1xf

I have just noticed, if i place this within the [qb] folder it always resets itself back to the original qbcore phone, i have tried two or three fresh downloads and each time it will revert unless i place it in a different folder - could this be causing some weird interaction?

llbooya commented 2 years ago

I noticed after recording this I didnt show the console but as mentioned in the original this is recreatable by any player at any time, all they have to do is hangup during a phonecall and as seen in the first clip it will stay on their screen

https://streamable.com/u6t1xf

I have just noticed, if i place this within the [qb] folder it always resets itself back to the original qbcore phone, i have tried two or three fresh downloads and each time it will revert unless i place it in a different folder - could this be causing some weird interaction?

have you deleted the old one and cleared cache? i cant reproduce this error on my end im curious can you see if you get an error of any kind?

Jxmes-Devs commented 2 years ago

I have cleared cache on both the server & client.

My process to install this new phone is: close server, delete both client & server caches. delete old qb-phone. drag & drop new qb-phone into [qb]. when I do it this way I get the old QB-phone appear so then i close server clear cache and place it in [standalone] and i get this css rework load but then get the aforementioned bug.

If it is of any note the QB version I am running is from around 01/01/2022.

https://i.imgur.com/VxgJk8A.png screenshot from console

Cautious to upload the screenshot from my server cmd but the only reference in there is one line after the phone is asnwered which reads:

mstsc_7NU8eZHUXR

llbooya commented 2 years ago

did you ever figure this out cause it isnt a widespread thing and i could never recreate it

dwiprizzy commented 1 year ago

any update for this error ?

Jxmes-Devs commented 1 year ago

I know at the time of posting, I found a fix that solved everything (I havent touched this stuff for upwards of 8 months at this time so my memory is patchy). I found the NUI messages that were being sent when the phonecall ended were being sent the wrong way round (the Outgoingcall was going to the incomingcall recipient & visa versa). As far as I am aware I simply switched the NUIMessages around and that solved it. (lines 368 - 421 for the 'CancelCall' function // namely the if statement starting on line 391)

I cannot give more details as when I check the files I still have locally they match back to the code found in this version.

dwiprizzy commented 1 year ago

@hdsunbed can you share the specific line ?

Jxmes-Devs commented 1 year ago

As mentioned should be the if statement starting on line 391

dwiprizzy commented 1 year ago

i think that a different script