search

lldb-tools / lldb-mi

LLDB's machine interface driver
https://lldb.llvm.org
Other
162 stars 53 forks source link

Avoid warnings by removing 'static' from templates that currently are unused #71

Closed mstorsjo closed 3 years ago

mstorsjo commented 3 years ago

This fixes warnings like these:

../src/MICmnLLDBDebugSessionInfo.cpp:877:17: warning: unused function 'GetBreakOrWatchPointAddress' [-Wunused-function] lldb::SBAddress GetBreakOrWatchPointAddress(lldb::SBTarget &vrTarget, ^ ../src/MICmnLLDBDebugSessionInfo.cpp:884:17: warning: unused function 'GetBreakOrWatchPointAddress' [-Wunused-function] lldb::SBAddress GetBreakOrWatchPointAddress(lldb::SBTarget &vrTarget, ^

Alternative they could be removed altogether.

tkrasnukha commented 3 years ago

Could you, please, remove the whole declaration and replace the template specializations with the regular overloads?

mstorsjo commented 3 years ago

Could you, please, remove the whole declaration and replace the template specializations with the regular overloads?

Ok, updated that way, I think.

They're still unused though, and now they are non-static functions. If I would keep static on each of the overloads, the compiler would warn that they're unused still though.

tkrasnukha commented 3 years ago

Really, looks like this code was committed mistakenly and should be removed. Thank you for catching that!

mstorsjo commented 3 years ago

Really, looks like this code was committed mistakenly and should be removed. Thank you for catching that!

Ok, updated the patch to remove those functions altogether.