llde / xOBSE

Oblivion Script extender source
243 stars 35 forks source link

Changed static const integral globals to static constexpr. #214

Closed calebtt closed 11 months ago

calebtt commented 11 months ago

Changed NULL to nullptr.

Added some usages of 'auto'.

Fixed potential bug in SetDescriptionTextForForm.

Added header to stdafx, added define to remove awful min/max macros from windows.h before the inclusion, fixed one single usage of min/max macros--replaced with std lib std::min and std::max.

Marked some variables at function scope const.

Added explicit cast to 'float' from 'double' in GetPlayerSpellEffectiveness.

Line 1001, changed a UInt32 from being initialized to 'false' to uniform initialization default, 0.

Line 1164, changed if( container.size() ) to if( !container.empty() ).

Line 1640, changed raw C array inside function to std::array and made for loop bounds-checked.

calebtt commented 11 months ago

@llde Here is a PR if you want to look at it.

calebtt commented 11 months ago

uhh I accidentally added a visual studio options file in there, will remove that