search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
354 stars 40 forks source link

Fixed Compilation without VRC and Console warnings #155

Closed float3 closed 2 years ago

float3 commented 2 years ago

compilation tested with UdonSharp + SDK, just Avatar SDK, and without either SDK

though this doesn't fix the issue that script references would still be broken without UdonSharp

pema99 commented 2 years ago

Did you use latest U# to test?

Also, have you checked if thus actually compiles without UdonSharp now? I think some class definitions might still be needing guards (UdonSharpBehaviour VS MonoBehaviour)

float3 commented 2 years ago

Did you use latest U# to test?

Also, have you checked if thus actually compiles without UdonSharp now? I think some class definitions might still be needing guards (UdonSharpBehaviour VS MonoBehaviour)

I used UdonSharp v1.0.0b8 I didn't get any compilation errors in a project with just this (no U#, no Avatar SDK, no World SDK) Script references are broken though and I didn't test functionality

yewnyx commented 2 years ago

Yewnyx submitted a PR which does something similar to this. Depending on what lands first, you might have to address some merge conflicts, just heads up

I'm not territorial, I don't mind dropping mine

float3 commented 2 years ago

Yewnyx submitted a PR which does something similar to this. Depending on what lands first, you might have to address some merge conflicts, just heads up

I checked it out.

Yewnyx submitted a PR which does something similar to this. Depending on what lands first, you might have to address some merge conflicts, just heads up

I'm not territorial, I don't mind dropping mine

it definitely looks like you are planning to do quite a bit more than me here, I am just fixing some things that were bothering me

yewnyx commented 2 years ago

I'll rebase it after and talk to cn, nbd.

pema99 commented 2 years ago

Did you use latest U# to test? Also, have you checked if thus actually compiles without UdonSharp now? I think some class definitions might still be needing guards (UdonSharpBehaviour VS MonoBehaviour)

I used UdonSharp v1.0.0b8 I didn't get any compilation errors in a project with just this (no U#, no Avatar SDK, no World SDK) Script references are broken though and I didn't test functionality

Oh, U# 1.0. I've been trying to stick to pre-1.0 versions since in my experience recompiling assets with newer versions can break them for older ones. 1.0 isn't really released yet. I'm gonna verify if I have errors when opening the project with latest released version.

float3 commented 2 years ago

I initially used the latest release package on the U# GitHub but AL was throwing errors so I switched

pema99 commented 2 years ago

Ok, I tested with 0.20 with your changes and it looks like everything is in order. Thanks for the contribution.