llealloo / audiolink

Audio reactive prefabs for VRChat
Other
354 stars 40 forks source link

Adjust null checks for the audioSource #180

Closed techanon closed 2 years ago

techanon commented 2 years ago

This prevents AudioLink script from crashing when an audioSource is not present, as it might only be assigned during runtime instead of in editor.
Add a warning to notify users about the missing audioSource in case it was unintentional.

llealloo commented 2 years ago

Seems like a good qol improvement at no cost, thanks!

Not sure what the change is in Update?

techanon commented 2 years ago

The change in Update is moving another reference to audioSource inside an already existing null check image

pema99 commented 2 years ago

This is totally reasonable. Thanks