search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
354 stars 40 forks source link

Add ThemeColor controller #181

Closed DomNomNom closed 2 years ago

DomNomNom commented 2 years ago

Re-purposes the bottom of the controller to show current theme colors

Adds a selection for themecolor mode and displays current theme color: image

Adds a controller to change the custom theme colors image

pema99 commented 2 years ago

This PR shouldn't be against master, please retarget to dev. More pressingly, it sort of looks like you based your branch of an old version of master? The diff is huge has conflicts with dev.

DomNomNom commented 2 years ago

Fixed the base / conflicts

pema99 commented 2 years ago

This looks great. Thanks for doing it, the theme colors are feeling like a real feature now. I've added a few minor comments.

About the networking code added to support the customizable theme colors, have you tested it? In my experience it can be quite tricky to get Udon networking code right, so I'd like to know if you'v verified it with multiple VRC clients.

pema99 commented 2 years ago

Seems like the upgrade logic works fine