Closed DomNomNom closed 2 years ago
This PR shouldn't be against master, please retarget to dev. More pressingly, it sort of looks like you based your branch of an old version of master? The diff is huge has conflicts with dev.
Fixed the base / conflicts
This looks great. Thanks for doing it, the theme colors are feeling like a real feature now. I've added a few minor comments.
About the networking code added to support the customizable theme colors, have you tested it? In my experience it can be quite tricky to get Udon networking code right, so I'd like to know if you'v verified it with multiple VRC clients.
Seems like the upgrade logic works fine
Re-purposes the bottom of the controller to show current theme colors
Adds a selection for themecolor mode and displays current theme color:![image](https://user-images.githubusercontent.com/888068/167820451-8fcac224-ea89-4d64-a3c8-0deed8bdfc85.png)
Adds a controller to change the custom theme colors![image](https://user-images.githubusercontent.com/888068/167820720-6d0b0092-09c4-41df-9cf3-a3f9e5f3a7eb.png)