search

llealloo / audiolink

Audio reactive prefabs for VRChat
Other
354 stars 40 forks source link

Creates VPM-Compatible Package #188

Closed momo-the-monster closed 2 years ago

momo-the-monster commented 2 years ago

Replaces shader include paths with new Packages paths Separates scripts into Runtime / Editor and adds Assembly Definition Files Adds Package Manifest

float3 commented 2 years ago

The AudioLinkSandbox folder should probably either be moved into the assets folder or be part of the package.

pema99 commented 2 years ago

AudioLinkSandbox is for stuff we don't want to distribute, so it shouldn't be in the package. It can go in the project, I think.

pema99 commented 2 years ago

Got a bit caught up in something over the weekend. I'll take a proper look at this soon 😅 My gut feel is that it can just land as is, and we'll fix up any minor gripes with folder structure etc.

float3 commented 2 years ago

AudioLinkSandbox is for stuff we don't want to distribute, so it shouldn't be in the package. It can go in the project, I think.

It is currently included in the "AudioLink Full.unitypackage", right? Though for VPM purposes, it should probably be excluded from the package.

pema99 commented 2 years ago

It isn't in either unitypackage

pema99 commented 2 years ago

Waiting to sort out / investigate some remaining issues relating the install workflow

pema99 commented 2 years ago

Merging this now, and we fix remaining issues afterwards